Conversation
* equality comparer and queries updated * data model, importers and importstorage updated * scenario avalinade for datanodes * scenario test improved * firsts comments resolved * all comments resolved * scenario test works * estimate type fix * more scenario tests * revert calculation engine notebook * improved union of target/default variables * full union + save zeros for scenarios * scenario tests are green * fix equality comparer * best estimate all green * ifrs variables scenario new benchmark * openings importer cleanups * first implementation of yield curve importer * fix report benchmark scenario * cleanup * preparation before pull develop * scenario for GOC removed * YieldCurves new format added. * more readable relaxed query util method * warning triggering multiple calculation * cleanup the importer * comments on warning implemented * test clean up * YieldCurve Importer now trigger calculation * fix report variables benchmark * test coverage improved * some comments resolved * validation added * new args datamodel, bm with standard digits * Useless Zeros not saved, code cleanup * comments on EqualityComparer resolved, BM updated * Test Improved * comments resolved * refactoring of Main Parser, all tests green * typo fixing * importer and test for yield curve improved * code improvment and cleanup * code cleanup * Name property in YieldCurve Implemented * bug fix, all test green * commit to DB only with succeeded import * yield curve updated * new yield curves files created * comment resolved * some comments resolved * renames and markdown and use of .Any * code improvments * test debug * cleanup merge errors * code cleanup * typo fix, test and importer improved * best * implement feedback * feedback v2: consistency and readability up * add toggle * commit partition renaming * improved toggle + better relaxed queries * make args and storage initializer more robust * pv cleanups Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com>
Place importFormat string outside of variable
* fix and test * fix YC query bm and refine locked int month defition + add a tests
* Adapting the tests (AocStructureTest, ImportStorageTest, ReportStorageTest, TechnicalMarginTest) so that they can be executed in the Engine. * Cleanup. * Enhancements - reducing import string sizes. * Optimizing data. * Bug fix, and updating the data to the newest changes in the develop. * Davide's feedback. * More Davide's feedback. * Importing entire ProjectionConfiguration instead. * Proper import of the CE * Solving an issue with yield curve changes. * better way of solving the issue with the yield curve change. * Removing commits, as the tests now run in memory. * Fixing a bugg in ReportStorageTest and making the tests run in the tests file * Fixing the amount types
Moving the tests, adapting the tests notebooks and removing the unnecessary code for the DataSource reset. Also the imports are suitabler
* Adding mandatory AoC step exception in the filter and adding warnings for not importing mandatory AoC steps- * Including Andreas feedback * Adding a warning for missing aoc steps import. * Removing bugs * Aesthetics * Andreas feedback implementation. * Working on Expressions. * Making the reader function work. * Implementing into Importers. * Reverting the changes from the merge. * Cleanup. * Andreas feedback implementation * Adding imports. * Adaptations and aesthetics. * Simplifying the diff. * Simplifying the diff. * A fix. * Corrected merging conflicts. * Cleaning the diff (a bit). * Reseting a change. * Implementing Daniels feedback. * Reverting some change. * Improvement. * Replacing ToString for ToIdentityString. * ToIdentityString update * Proposition 1 * Improvement * some refactors
* improving import: fix opening and Fix CommitToAsync to deal with physical db * clean up * clean up * add test for cf * rename file and correct memory usage
* param report and queries nb * update template readme * update overviews * v100 to v110 links update * typos * refer to v1.1.0
nnikolopoulos
approved these changes
Jan 30, 2023
remove parent from RN in Dimensions.xlsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.1.0