Skip to content

replaced print functions by print_table#900

Merged
annawendler merged 1 commit intomainfrom
797-replace-print_result-in-ide-models
Jan 18, 2024
Merged

replaced print functions by print_table#900
annawendler merged 1 commit intomainfrom
797-replace-print_result-in-ide-models

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Jan 15, 2024

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • replaced print functions by print_table in ide secir and seir

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #797

@lenaploetzke lenaploetzke linked an issue Jan 15, 2024 that may be closed by this pull request
2 tasks
@lenaploetzke lenaploetzke self-assigned this Jan 15, 2024
@lenaploetzke lenaploetzke added the model::ide This issue concerns any kind of integro differential equations-based model. label Jan 15, 2024
@codecov
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe6109c) 95.60% compared to head (6cdd814) 95.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   95.60%   95.89%   +0.28%     
==========================================
  Files         118      118              
  Lines        9448     9420      -28     
==========================================
  Hits         9033     9033              
+ Misses        415      387      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawendler annawendler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@annawendler annawendler merged commit 1fa9e20 into main Jan 18, 2024
@annawendler annawendler deleted the 797-replace-print_result-in-ide-models branch January 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model::ide This issue concerns any kind of integro differential equations-based model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace print_result in IDE models

2 participants