Skip to content

677 final version secir reproduction number#858

Merged
mknaranja merged 4 commits intomainfrom
677-computation-of-the-effective-reproduction-number-in-the-secir-model_v3
Jan 5, 2024
Merged

677 final version secir reproduction number#858
mknaranja merged 4 commits intomainfrom
677-computation-of-the-effective-reproduction-number-in-the-secir-model_v3

Conversation

@johapau
Copy link
Collaborator

@johapau johapau commented Dec 4, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

@johapau johapau requested a review from HenrZu December 4, 2023 14:57
@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8851202) 95.40% compared to head (4027f16) 95.55%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   95.40%   95.55%   +0.15%     
==========================================
  Files         117      118       +1     
  Lines        9231     9414     +183     
==========================================
+ Hits         8807     8996     +189     
+ Misses        424      418       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johapau johapau requested a review from HenrZu December 8, 2023 10:08
@mknaranja mknaranja merged commit c18828e into main Jan 5, 2024
@mknaranja mknaranja deleted the 677-computation-of-the-effective-reproduction-number-in-the-secir-model_v3 branch January 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Computation of the Effective Reproduction Number in the SECIRVVS Model Computation of the Effective Reproduction Number in the SECIR Model

3 participants