Merged
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 167 167
Lines 14950 14960 +10
=======================================
+ Hits 14533 14543 +10
Misses 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reneSchm
requested changes
May 27, 2025
Member
reneSchm
left a comment
There was a problem hiding this comment.
Nice work, needs a few minor changes, and a comment per test that briefly describes what is tested (so other devs know why the test exists and what result is expected).
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
12 tasks
reneSchm
requested changes
Jun 3, 2025
Member
reneSchm
left a comment
There was a problem hiding this comment.
The coverage -.03% is annoying, can you try merging main? Codecov compares against an older commit, so maybe that helps?
Otherwise just some small suggestions left.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)