Skip to content

1154 integrator is handled as adaptive if using small fixed step sizes#1155

Merged
reneSchm merged 4 commits intomainfrom
1154-integrator-is-handled-as-adaptive-if-using-small-fixed-step-sizes
Dec 13, 2024
Merged

1154 integrator is handled as adaptive if using small fixed step sizes#1155
reneSchm merged 4 commits intomainfrom
1154-integrator-is-handled-as-adaptive-if-using-small-fixed-step-sizes

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Dec 6, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added tolerance in the calculation of m_is_adaptive.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1154

@lenaploetzke lenaploetzke self-assigned this Dec 6, 2024
@lenaploetzke lenaploetzke linked an issue Dec 6, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (f76d14f) to head (d7d2bf7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   96.98%   96.95%   -0.03%     
==========================================
  Files         142      148       +6     
  Lines       11873    13715    +1842     
==========================================
+ Hits        11515    13298    +1783     
- Misses        358      417      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke requested a review from reneSchm December 6, 2024 13:00
lenaploetzke and others added 2 commits December 12, 2024 15:30
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
@lenaploetzke
Copy link
Member Author

I don't know what the problem is with codecov again.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are good.

The coverage can be ignored, IMO. My guess is that some tests are written with their coverage depending on rng, so it shifts with every run, causing all these minute indirect changes.

@reneSchm reneSchm merged commit 754675b into main Dec 13, 2024
@reneSchm reneSchm deleted the 1154-integrator-is-handled-as-adaptive-if-using-small-fixed-step-sizes branch December 13, 2024 09:28
@reneSchm reneSchm mentioned this pull request Jan 3, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrator is handled as adaptive if using small fixed step sizes

2 participants