Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
+ Coverage 96.95% 96.97% +0.01%
==========================================
Files 148 148
Lines 13715 13718 +3
==========================================
+ Hits 13298 13303 +5
+ Misses 417 415 -2 ☔ View full report in Codecov by Sentry. |
|
@reneSchm Please update readmes :) |
mknaranja
left a comment
There was a problem hiding this comment.
Thank you for the updates. I gave some more or less informed comments. Maybe check for them, update the readmes and then it should be OK.
|
Thanks for the review @mknaranja. Please check the "additional information for reviewers", in case you haven't. I had made Eigen a system library, so we do not need to manually add compiler diagnostics. I hadn't removed them before your review (see here). I also replaced mio::Vector by Eigen::VectorX (new in 3.4.0) in that commit, so it is more obvious that Vector is a Eigen type and not something we wrote ourselves. |
mknaranja
left a comment
There was a problem hiding this comment.
Looks good. There is just one comment / discussion we should agree on.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1167