Skip to content

Conversation

@MichaelChirico
Copy link
Member

Follow-up to #6090 -- since it seems this suite has not been run lately in CI, I tried locally and found it's not passing, fixed here.

Note that options(warn=1) in tests/other.R was doing nothing, since test.data.table() always sets warn=0:

warn = 0L, # ensure signals are emitted as they are in the code, #5285

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your diligence Michael

@MichaelChirico MichaelChirico merged commit 20126b1 into master Apr 22, 2024
@MichaelChirico MichaelChirico deleted the test-other branch April 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants