Skip to content

Conversation

@MichaelChirico
Copy link
Member

Closes #2651

@tdhock
Copy link
Member

tdhock commented Apr 19, 2024

looks reasonable but I wonder if it could be simplified at all?
Also is other.Rraw regularly checked? (I guess not on CRAN, but on CI?)

@MichaelChirico
Copy link
Member Author

could be simplified at all?

Good point, I tried to stay as close to the original issue as possible -- since we're not sure precisely what changed to fix it, it's possible we'll oversimplify and wind up with a test that's not actually a regression test. That said, the first step with the ugly gsub() can certainly be dropped, so I did that. I think it's pretty straightforward now, WDYT?

Also is other.Rraw regularly checked? (I guess not on CRAN, but on CI?)

It's in our main test suite, but only runs with the right env:

if (!as.logical(Sys.getenv("TEST_DATA_TABLE_WITH_OTHER_PACKAGES", "FALSE"))) {

This comment says it's run in GLCI, but I don't see that env set in our config, nor any reference to 'other.Rraw':

# TEST_DATA_TABLE_WITH_OTHER_PACKAGES is off by default so this other.Rraw doesn't run on CRAN. It is run by GLCI, locally in dev, and by

@jangorecki am I missing something?

@MichaelChirico MichaelChirico merged commit 6f3fc8d into master Apr 19, 2024
@MichaelChirico MichaelChirico deleted the magrittr-plonk branch April 19, 2024 18:04
@jangorecki
Copy link
Member

Yes, history of glci yaml will have the answer, of and at which point it was switched off

@MichaelChirico
Copy link
Member Author

#5758 removed here but without comment about why other.Rraw was excluded

@jangorecki
Copy link
Member

jangorecki commented Apr 22, 2024

AFAIR Matt removed DESCRIPTION-others file and dependencies (all or some?) were not automatically resolved in CI, therefore it was switched off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow column type changes when the as.* call comes at the end of a pipe chain

3 participants