Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5984 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 80 80
Lines 14884 14884
=======================================
Hits 14513 14513
Misses 371 371 ☔ View full report in Codecov by Sentry. |
|
@jangorecki did I get the tag right? We are getting an error that it's not available IINM |
|
We don't have image for R 3.2.0 built in the registry: https://gitlab.com/jangorecki/dockerfiles/container_registry |
|
Filed https://gitlab.com/jangorecki/dockerfiles/-/merge_requests/2, anything else we need to do? |
|
Ah, found the other related PR: #5906. Let's merge this first to get GLCI back up & running. Marking that as draft for now. |
|
@tdhock do you go by the same username on GitLab? Just realized we should add you as a Member over there too in case you ever need to test changes to GLCI. I also see a |
|
hmm I guess they are both me, but I haven't used either in years |
|
@jangorecki ping on the gitlab MR |
|
MR was merged 2 weeks ago already. |
|
Current CI config looks quite different from your reference, I'm not sure how to proceed: https://gitlab.com/jangorecki/dockerfiles/-/blob/master/.gitlab-ci.yml?ref_type=heads |
OK, in any case I sent an invite. Can't hurt. |
|
@jangorecki could still use your help on the the dockerfiles repo... in particular I also send an MR for the 3.3.0 tag. There are 3 pending MRs over there: https://gitlab.com/jangorecki/dockerfiles/-/merge_requests Thanks! |
|
Thanks for reminder, I will add Ben @ben-schwen later today to this repo so he can merge MR easily. We could possibly move this repo to the org, because I recall on my username I was barely fitting within CI minutes quota. |
I assume that means the GitLab org. On GitHub side, |
|
yes, added Ben now |
|
LGTM (I also pushed the 3.3.0 docker image to our container repo yesterday) |
Closes #5978
I couldn't find which PR we discussed this previously, but anyway this should cover us for getting 3.2.0 test back up & running.