Update repo-level references for 3.2.0#5906
Closed
MichaelChirico wants to merge 24 commits intomasterfrom
Closed
Conversation
MichaelChirico
changed the title
MichaelChirico
commented
Jan 12, 2024
jangorecki
reviewed
Jan 12, 2024
README.md
Outdated
Member
There was a problem hiding this comment.
This line will have a merge conflict with one of my PRs where it was updated, to avoid numbers that has to be continuously updated.
Member
Author
There was a problem hiding this comment.
would you mind linking which PR? happy to do the branch update after merging here. seems like this one should come first since DESCRIPTION lists 3.2.0.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
OK, I think the new wording on this PR is to be preferred.
jangorecki
reviewed
Jan 12, 2024
* Fix 5492 by limiting the costly deparse to `nlines=1` * Implementing PR feedbacks * Added inside * Fix typo in name * Idiomatic use of inside * Separating the deparse line limit to a different PR --------- Co-authored-by: Michael Chirico <chiricom@google.com>
* Added my improvements to the intro vignette * Removed two lines I added extra as a mistake earlier * Requested changes
* fix typos and grammatical mistakes * fix typos and punctuation * remove double spaces where it wasn't necessary * fix typos and adhere to British English spelling * fix typos * fix typos * add missing closing bracket * fix typos * review fixes * Update vignettes/datatable-benchmarking.Rmd Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * Update vignettes/datatable-benchmarking.Rmd Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * Apply suggestions from code review benchmarking Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * remove unnecessary [ ] from datatable-keys-fast-subset.Rmd * Update vignettes/datatable-programming.Rmd Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * Update vignettes/datatable-reshape.Rmd Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * One last batch of fine-tuning --------- Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Michael Chirico <chiricom@google.com>
* Updated documentation for rbindlist(fill=TRUE) * Print NULL entries of list as NULL * Added news item * edit NEWS, use '[NULL]' not 'NULL' * fix test * split NEWS item * add example --------- Co-authored-by: Michael Chirico <chiricom@google.com> Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Benjamin Schwendinger <benjamin.schwendinger@tuwien.ac.at>
* clarify that list input->unnamed list output * Add example where make.names is used * mention role of make.names
* fix subsetting issue in split.data.table * add a test * drop=FALSE on inner [
* Allow early exit from check for eval/evalq in cedta Done in the browser+untested, please take a second look :) * Use %chin% * nocov new code
* frollmax exact, buggy fast, no fast adaptive * frollmax fast fixing bugs * frollmax man to fix CRAN check * frollmax fast adaptive non NA, dev * froll docs, adaptive left * no frollmax fast adaptive * frollmax adaptive exact NAs handling * PR summary in news * copy-edit changes from reviews Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com> * comment requested by Michael * update NEWS file * Apply suggestions from code review Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * Apply suggestions from code review Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * add comment requested by Michael * add comment about int iterator for loop over k-1 obs * extra comments * Revert "extra comments" This reverts commit 03af0e3. * add comments to frollmax and frollsum * typo fix --------- Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com>
* friendlier error in assignment with trailing comma e.g. `DT[, `:=`(a = 1, b = 2,)`. WIP. Need to add tests and such, but editing from browser before I forget. * Another pass * include unnamed indices on RHS too * tests * NEWS * test numbering * explicit example in NEWS
MichaelChirico
force-pushed
the
1-15-99
branch
from
1edf380 to
f658ff4
Compare
MichaelChirico
force-pushed
the
3-2-0-ci
branch
from
1a13399 to
a26f990
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5906 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 80 80
Lines 14857 14857
=======================================
+ Hits 14483 14484 +1
+ Misses 374 373 -1 ☔ View full report in Codecov by Sentry. |
MichaelChirico
force-pushed
the
1-15-99
branch
from
0f38eda to
c0c19ea
Compare
MichaelChirico
force-pushed
the
1-15-99
branch
3 times, most recently
from
0ff8f67 to
8e2cc18
Compare
jangorecki
reviewed
Aug 29, 2024
Member
jangorecki
left a comment
jangorecki
left a comment
There was a problem hiding this comment.
Not sure but there may be also change required in CI summary table produced in integration stage. @ben-schwen do that ring any bells?
Member
Yes, but AFAICT we already did this see also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5905