extend g[ to work for tail queries like x[.N]#4810
Draft
MichaelChirico wants to merge 1 commit intomasterfrom
Draft
extend g[ to work for tail queries like x[.N]#4810MichaelChirico wants to merge 1 commit intomasterfrom
MichaelChirico wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
@ben-schwen any high-level comments here before I try and update to current |
Member
Nah, I guess lessons learned in #5548 and #5887 should be enough and actually should make this a lot smoother. Ideally, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4809
The idea is to detect
x[.N - k]cases and send them tog[, which gets a new argumentfromLast(defaultFALSE), sox[1L]becomes"g["(x, 1L, FALSE)andx[.N-2L]becomes"g["(x, 2L, TRUE). Logic forx[.N]is basically the same as forglast.Two things for feedback:
jsubfeels somewhat redundant (running roughly same somewhat long list of checks onjsuba second time)fromLast=FALSEcases -- in particularDT[,x[0],id]behaves differently thanDT[,x[.N+1],id]-- any suggestions for how to implement this cleanly? Maybe it should be an error instead of allowing it and returningNA? That's not very nice (e.g. the workaround of suggesting thebase::alternative is quite clunky for[) & would probably break some code.