Skip to content

fix: missing default parameters in smash config #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begumcig merged 1 commit into from
Jan 20, 2026
Merged

fix: missing default parameters in smash config #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/pruna/config/smash_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,14 @@ def load_from_json(self, path: str | Path) -> None:
saved_values = {k: v for k, v in config_dict.items() if k in supported_hparam_names}

# Seed with the defaults, then overlay the saved values
default_values = dict(SMASH_SPACE.get_default_configuration())
default_values.update(saved_values)

self._configuration = Configuration(SMASH_SPACE, values=default_values)
self._configuration = SMASH_SPACE.get_default_configuration()
# activate all algorithms already in the space to make children hyperparameters appear
saved_algorithm_keys = set(self._configuration.keys()) & set(saved_values.keys())
for key in saved_algorithm_keys:
self._configuration[key] = True
# register all saved hyperparameters
for key, value in saved_values.items():
self._configuration[key] = value

tokenizer_path = Path(path) / TOKENIZER_SAVE_PATH
if tokenizer_path.exists():
Expand Down