Skip to content

fix: missing default parameters in smash config#496

Merged
begumcig merged 1 commit intomainfrom
fix/missing-default-parameter-in-smash-config
Jan 20, 2026
Merged

fix: missing default parameters in smash config#496
begumcig merged 1 commit intomainfrom
fix/missing-default-parameter-in-smash-config

Conversation

@gsprochette
Copy link
Copy Markdown
Collaborator

Description

This PR fixes a legacy related bug where loading a saved SmashConfig with missing hyperparameters for an algorithm (e.g. target modules for hqq_diffusers) would result in an error from the load_from_json function stating that the hyperparameter is missing.

This was due to a discrepency between parent/children hyperparameter coverage between SMASH_SPACE's get_degault_configuration and Configurations's values argument.

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@gsprochette gsprochette requested a review from begumcig January 20, 2026 14:36
Copy link
Copy Markdown
Member

@begumcig begumcig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooooooo

@begumcig begumcig merged commit 4c7deea into main Jan 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants