feat: switch pruna from poetry to uv by johnrachwan123 · Pull Request #164 · PrunaAI/pruna

johnrachwan123 · 2025-05-30T07:53:25Z

Description

Related Issue

Fixes #30

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Additional Notes

GreatBahram · 2025-05-30T09:10:03Z

Hello there! 👋

I can’t directly push to this PR. You can find the related PR here, and then we can merge them together.

davidberenstein1957 · 2025-06-10T08:37:37Z

@johnrachwan123 don't forget to update the development docs. https://docs.pruna.ai/en/stable/docs_pruna/contributions/how_to_contribute.html

johnrachwan123 · 2025-06-10T14:07:11Z

@johnrachwan123 don't forget to update the development docs. https://docs.pruna.ai/en/stable/docs_pruna/contributions/how_to_contribute.html

Done :) Thanks for the reminder!

GreatBahram · 2025-06-11T19:14:58Z

Here, considering the long-term changes; what if we just link to the uv installation page

I agree this would be better. I think we can just add this to the uv section above as well.

good like this ?

GreatBahram · 2025-06-11T19:15:58Z

Two things:

I wonder if it makes sense to merge tests and dev into each other? I don't see that much benefit having them separate 🤷

It would be nice to use: uv sync --frozen

Hey we have an internal project to address these points in a later PR!

Cool, I can also give a hand after merging this

davidberenstein1957 · 2025-06-12T13:51:44Z

I agree this would be better. I think we can just add this to the uv section above as well.

* feat: attempt to swtich pruna from poetry to uv * fix: uv installation * refactor: remove requirements.txt * format the pyproject.toml properly + point to the license file * change linting file to use uv * use latest version of checkout * use latest version of setup-python * change documentation file to use uv * use latest version of setup-python * change external_tests file to use uv * change internal_tests file to use uv + prefix previous command to use uv * change installation file to use uv * change package_buil;d file to use uv + add retention policy there * tests: update package build to uv * remove poetry from gitignore * format the pyproject.toml properly + point to the license file * change package_buil;d file to use uv + add retention policy there * reduce the diff * add alaki file (random file); hopefully to triggers most of the workflows * Delete src/pruna/alaki.py * build: bump actions/setup-python from 3 to 5 (#193) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v3...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: bump abatilo/actions-poetry from 2 to 4 (#195) Bumps [abatilo/actions-poetry](https://github.com/abatilo/actions-poetry) from 2 to 4. - [Release notes](https://github.com/abatilo/actions-poetry/releases) - [Changelog](https://github.com/abatilo/actions-poetry/blob/master/.releaserc) - [Commits](abatilo/actions-poetry@v2...v4) --- updated-dependencies: - dependency-name: abatilo/actions-poetry dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: bump actions/cache from 3 to 4 (#196) Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build: bump actions/checkout from 3 to 4 (#194) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pyproject.toml * build: update ctranslate2 requirement from ==4.5.0 to ==4.6.0 (#199) Updates the requirements on [ctranslate2](https://github.com/OpenNMT/CTranslate2) to permit the latest version. - [Release notes](https://github.com/OpenNMT/CTranslate2/releases) - [Changelog](https://github.com/OpenNMT/CTranslate2/blob/master/CHANGELOG.md) - [Commits](OpenNMT/CTranslate2@v4.5.0...v4.6.0) --- updated-dependencies: - dependency-name: ctranslate2 dependency-version: 4.6.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * this is gone on main * enable caching in order to expedite the installtion time * just a test * Remove commented-out step for deleting .so files from linting workflow --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: johnrachwan123 <johnrachwan@gmail.com> Co-authored-by: David Berenstein <david.m.berenstein@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

GreatBahram · 2025-06-18T10:16:24Z

-        run: pip install -e .
+        run: |
+          uv venv
+          uv pip install -e .


Either this or you can also say activate-environment: true in with block of the install uv step; I wanted to do this later after you merge this PR, to create a common github action file and put the whole installation logic with activate-environment: true there which means we don't need to prefix every command with uv

GreatBahram · 2025-06-18T10:17:02Z

🔥

johnrachwan123 mentioned this pull request May 30, 2025

Feature: switch from poetry to uv #162

Closed

15 tasks

GreatBahram reviewed May 30, 2025

View reviewed changes

Comment thread pyproject.toml Outdated

GreatBahram reviewed Jun 10, 2025

View reviewed changes

Comment thread .github/workflows/package_build.yaml

johnrachwan123 force-pushed the feat/switch-pruna-from-poetry-to-uv branch from a0de480 to e2eeecb Compare June 10, 2025 13:24

johnrachwan123 requested review from davidberenstein1957 and johannaSommer June 10, 2025 14:07

This was referenced Jun 10, 2025

build: update whisper-s2t requirement from ==1.3.0 to ==1.3.1 #197

Closed

build: update hqq requirement from <0.2.7 to <0.2.8 #198

Closed

johnrachwan123 force-pushed the feat/switch-pruna-from-poetry-to-uv branch from d5fb729 to f2310fd Compare June 11, 2025 12:59

GreatBahram reviewed Jun 11, 2025

View reviewed changes

davidberenstein1957 reviewed Jun 12, 2025

View reviewed changes

johannaSommer requested changes Jun 18, 2025

View reviewed changes

Comment thread .github/workflows/cpu_tests.yaml Outdated

Comment thread .github/workflows/documentation.yaml Outdated

Comment thread .github/workflows/installation.yaml Outdated

Comment thread .github/workflows/linting.yaml Outdated

Comment thread pyproject.toml Outdated

johnrachwan123 and others added 10 commits June 18, 2025 09:28

feat: attempt to swtich pruna from poetry to uv

3fb24d2

fix: uv installation

9ce7bb0

refactor: remove requirements.txt

d08c275

tests: update package build to uv

63a6e1c

docs: update the how to contribute docs

d97c284

docs: expand how to contribute

150c697

fix: ctranslate2 and ws2t versions

e0b5ec6

fix: pin hqq version

c9050ab

fix: handle pr comments

6bb200a

johnrachwan123 force-pushed the feat/switch-pruna-from-poetry-to-uv branch from 52c2294 to 6bb200a Compare June 18, 2025 09:28

johnrachwan123 added 3 commits June 18, 2025 09:37

fix: typo in installation.yaml

099f14a

fix: typos in yaml files

3cc28fe

fix: use uv add

5ecb4e4

johnrachwan123 added 3 commits June 18, 2025 09:57

fix: add --system to pip install

3004511

fix: add uv venv

7718cd4

fix: keep one extra index in toml file

d4a29b5

GreatBahram reviewed Jun 18, 2025

View reviewed changes

johnrachwan123 added 2 commits June 18, 2025 10:18

fix: attempt to make pruna pypi server secondary

7f90e0a

fix: add uv venv to documentation.yaml

8abe524

johnrachwan123 requested review from davidberenstein1957 and johannaSommer June 18, 2025 10:24

johnrachwan123 added 6 commits June 18, 2025 10:29

fix: attempt to fix problematic gptqmodel dependency

3dc750e

fix: remove cache for sanity check

3889a1e

fix: remove duplicate line

d1b7a12

fix: remove extra index

349de97

fix: use_cache=True

bcd76e5

fix: remove uv from doc build

422db7c

johannaSommer approved these changes Jun 18, 2025

View reviewed changes

johnrachwan123 merged commit 5884f68 into main Jun 23, 2025
7 checks passed

Conversation

johnrachwan123 commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

How Has This Been Tested?

Checklist

Additional Notes

Uh oh!

Uh oh!

GreatBahram commented May 30, 2025

Uh oh!

davidberenstein1957 commented Jun 10, 2025

Uh oh!

Uh oh!

johnrachwan123 commented Jun 10, 2025

Uh oh!

GreatBahram Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

davidberenstein1957 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

johnrachwan123 Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

GreatBahram Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnrachwan123 Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

GreatBahram Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidberenstein1957 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GreatBahram Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

GreatBahram commented Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

johnrachwan123 commented May 30, 2025 •

edited

Loading

GreatBahram Jun 11, 2025 •

edited

Loading