Skip to content

fix: example of xss in bad context using a dedicated profile field #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lirantal merged 1 commit into from
Aug 3, 2020
Merged

fix: example of xss in bad context using a dedicated profile field #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/routes/profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ function ProfileHandler (db) {
// while the developer intentions were correct in encoding the user supplied input so it
// doesn't end up as an XSS attack, the context is incorrect as it is encoding the firstname for HTML
// while this same variable is also used in the context of a URL link element
doc.firstNameSafeString = ESAPI.encoder().encodeForHTML(doc.firstName)
doc.website = ESAPI.encoder().encodeForHTML(doc.website)
// fix it by replacing the above with another template variable that is used for
// the context of a URL in a link header
// doc.doc.firstNameSafeURLString = ESAPI.encoder().encodeForURL(urlInput)
// doc.website = ESAPI.encoder().encodeForURL(doc.website)

return res.render("profile", doc);
});
Expand Down
5 changes: 5 additions & 0 deletions app/views/profile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ <h3 class="panel-title">Edit Profile</h3>
<label for="address">Address</label>
<input type="text" class="form-control" id="address" name="address" value="{{address}}" placeholder="Enter address">
</div>
<div class="form-group">
<label for="website">Website</label>
<input type="text" class="form-control" id="website" name="website" value="{{website}}"
placeholder="https://">
</div>
<input type="hidden" name="_csrf" value="{{csrftoken}}" />
<button type="submit" class="btn btn-default" name="submit">Submit</button>

Expand Down