fix: example of xss in bad context using a dedicated profile field#203
Merged
lirantal merged 1 commit intoOWASP:masterfrom Aug 3, 2020
lirantal:fix/xss-context
Merged
fix: example of xss in bad context using a dedicated profile field#203lirantal merged 1 commit intoOWASP:masterfrom lirantal:fix/xss-context
lirantal merged 1 commit intoOWASP:masterfrom
lirantal:fix/xss-context
Conversation
UlisesGascon
reviewed
Aug 4, 2020
Collaborator
There was a problem hiding this comment.
Looks great @lirantal! Just update the broken test and we fix the tests 💪
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR
The example of using proper context to perform output encoding is incorrect in terms of bad code, and example reference:
doc.doc.firstName..butdoc.docis incorrect and never really did work anyway. Also thefirstNameSafeStringtemplate variable in the view atprofile.htmlwas never assigned.FIXMEhint to encode it properly for HTML but the problem is that even if you encode it (either way), it still causes an XSS because other views use it, such as the drop-down profile name etc.This change
This PR fixes the issue by introducing another profile field
websitethat is never used anywhere, and can be mitigated easily with encoding, but if done improperly can still introduce an XSS, and theFIXMEclause of proper context encoding then makes sense.