Skip to content

Reduce unnecessary work in dependency builds #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sbryngelson wants to merge 4 commits into
base: master
Choose a base branch
from
+7 −3
Draft

Reduce unnecessary work in dependency builds #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58033cb
Reduce unnecessary work in dependency builds
sbryngelson Mar 28, 2026
ea00665
Reduce unnecessary work in dependency builds
sbryngelson Mar 28, 2026
10c55e5
Use cluster template for case-opt runs to avoid srun failures on Phoenix
sbryngelson Mar 28, 2026
d4dfd6d
Revert "Use cluster template for case-opt runs to avoid srun failures…
sbryngelson Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/simulation/m_global_parameters.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
!>
!! @file
!! @brief Contains module m_global_parameters
!! @brief Contains module m_global_parameters (simulation)

#:include 'case.fpp'
#:include 'macros.fpp'
Expand Down
8 changes: 6 additions & 2 deletions toolchain/dependencies/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,13 @@ if (MFC_HDF5)
GIT_PROGRESS ON
CMAKE_ARGS "-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}"
-DBUILD_SHARED_LIBS=OFF
-DFORTRAN_LIBRARIES=ON
-DBUILD_TESTING=OFF
-DHDF5_BUILD_UTILS=OFF
-DHDF5_BUILD_TOOLS=ON
-DHDF5_BUILD_EXAMPLES=OFF
-DHDF5_BUILD_CPP_LIB=OFF
-DHDF5_BUILD_FORTRAN=OFF
-DHDF5_ENABLE_PARALLEL=OFF
)
endif()
endif()
Expand All @@ -82,13 +84,15 @@ if (MFC_SILO)

ExternalProject_Add(silo
GIT_REPOSITORY "https://github.com/LLNL/Silo"
GIT_TAG 0cddaa6865fb49ae7b2110fa1b6f2709592abe0b
GIT_TAG 4.12.0
GIT_SHALLOW ON
GIT_PROGRESS ON
PATCH_COMMAND "${GIT_EXECUTABLE}" stash
&& "${GIT_EXECUTABLE}" apply "${CMAKE_SOURCE_DIR}/Silo.patch"
CMAKE_ARGS -DSILO_ENABLE_SHARED=OFF
-DSILO_ENABLE_SILOCK=OFF
-DSILO_ENABLE_BROWSER=OFF
-DSILO_ENABLE_ZFP=OFF
-DFIND_LIBRARY_USE_LIB64_PATHS=ON
"-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}"
"-DCMAKE_FIND_ROOT_PATH=${CMAKE_FIND_ROOT_PATH}"
Expand Down
Loading