Skip to content

Reduce unnecessary work in dependency builds#1338

Draft
sbryngelson wants to merge 4 commits intoMFlowCode:masterfrom
sbryngelson:fast-deps
Draft

Reduce unnecessary work in dependency builds#1338
sbryngelson wants to merge 4 commits intoMFlowCode:masterfrom
sbryngelson:fast-deps

Conversation

@sbryngelson
Copy link
Copy Markdown
Member

Summary

  • HDF5: Remove invalid -DFORTRAN_LIBRARIES=ON (not a real HDF5 CMake variable; was a no-op). Explicitly disable C++ bindings, Fortran bindings, and parallel I/O that MFC doesn't use — fewer source files to compile.
  • Silo: Add GIT_SHALLOW ON (was missing unlike other deps) and disable ZFP compression (-DSILO_ENABLE_ZFP=OFF). MFC never uses Silo compression, so this removes ~33 ZFP source files from the build.

Test plan

  • Build post_process from clean state, verify deps build and link correctly
  • Run post-process on a case that writes .silo output and confirm files are valid
  • Verify h5dump still works in test suite (HDF5 tools are still enabled)

- Remove invalid -DFORTRAN_LIBRARIES=ON from HDF5 (not a real HDF5
  variable); explicitly disable features MFC doesn't need:
  HDF5_BUILD_CPP_LIB, HDF5_BUILD_FORTRAN, HDF5_ENABLE_PARALLEL
- Disable ZFP compression in Silo (MFC never uses Silo compression)
- Add GIT_SHALLOW to Silo clone (was missing unlike other deps)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2026

Claude Code Review

Incremental review from: ea00665
Head SHA: 10c55e5

New findings since last Claude review:

  • $job_cluster is undefined in run_case_optimization.sh (line 47): The new -c "$job_cluster" argument references a variable that is never set in this script and is not listed as an expected injected environment variable. The file's own header comment (line 4) documents only $job_device and $job_interface as variables expected from submit.sh$job_cluster is absent. If unset at runtime, the command expands to -c "", passing an empty cluster name to ./mfc.sh run, which will either silently misbehave or error. The variable needs to either be exported by submit.sh (and documented in the header) or guarded in the script before use.

- Pin Silo to 4.12.0 release tag (instead of a post-release commit hash)
  so GIT_SHALLOW works, making the clone faster
- Disable ZFP compression in Silo (MFC never uses Silo compression)
- Remove invalid -DFORTRAN_LIBRARIES=ON from HDF5 (not a real HDF5
  variable); explicitly disable unneeded features: C++ bindings,
  Fortran bindings, and parallel I/O
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant