Skip to content

add site and mutation table rows#130

Merged
gregorgorjanc merged 6 commits intoHighlanderLab:mainfrom
bryo-han:add_sites_mutations
Apr 10, 2026
Merged

add site and mutation table rows#130
gregorgorjanc merged 6 commits intoHighlanderLab:mainfrom
bryo-han:add_sites_mutations

Conversation

@bryo-han
Copy link
Copy Markdown
Contributor

No description provided.

@bryo-han bryo-han requested a review from LynxJinyangii March 23, 2026 11:31
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bryo-han bryo-han requested a review from gregorgorjanc March 26, 2026 10:22
@gregorgorjanc
Copy link
Copy Markdown
Member

@LynxJinyangii can you review this PR while I am away?

@hannesbecher hannesbecher removed the request for review from gregorgorjanc March 27, 2026 09:00
@hannesbecher
Copy link
Copy Markdown
Contributor

I think @LynxJinyangii will be delighted to do so, @gregorgorjanc , as he is keen to base his additions on this PR.

@LynxJinyangii
Copy link
Copy Markdown
Collaborator

I've tested the functions with gh and eveything looks good to me.

@hannesbecher
Copy link
Copy Markdown
Contributor

@gregorgorjanc During the pre-commit check, jarl now complains about the use of the triple colon. I think this may be a new behaviour of the recently released version 0.5.0 of jarl. This is to make sure that things don't break in the future in case internal naming changes. I guess we need to review (again) what we want to export...

@gregorgorjanc
Copy link
Copy Markdown
Member

Yeah, I got the same error in previous PR merge too https://github.com/HighlanderLab/RcppTskit/actions/runs/23729353545/job/69119640231

We can tell jarl to ignore some lines. I have used that in a couple of places in the package.

I am sitting in the fence atm on wether we should or shouldn't export rtsk_* R&C++ functions. Let's wait a bit and see what the future brings;)

@bryo-han bryo-han force-pushed the add_sites_mutations branch from 43eb760 to 6be0402 Compare April 2, 2026 10:43
@gregorgorjanc
Copy link
Copy Markdown
Member

@bryo-han @LynxJinyangii I have now done a polish of these add_row functions, so that we have the same style across all of them - more testing on R side than C++ side and consistent mapping with Python and C arg orders and types etc. Will wait for the GitHub Actions to run, but pre-commit and R CMD checks seems good already.

@gregorgorjanc gregorgorjanc merged commit 45a4656 into HighlanderLab:main Apr 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants