Add create_event function to create event string#71
Merged
dgarciabriseno merged 9 commits intoHelioviewer-Project:mainfrom Aug 29, 2022
Merged
Add create_event function to create event string#71dgarciabriseno merged 9 commits intoHelioviewer-Project:mainfrom
create_event function to create event string#71dgarciabriseno merged 9 commits intoHelioviewer-Project:mainfrom
Conversation
nabobalis
reviewed
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 99.51% 99.53% +0.01%
==========================================
Files 24 24
Lines 622 640 +18
==========================================
+ Hits 619 637 +18
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dgarciabriseno
approved these changes
Aug 25, 2022
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
nabobalis
force-pushed
the
event_strings_workaround
branch
from
167a9e8 to
9b2bbf5
Compare
nabobalis
reviewed
Aug 28, 2022
dgarciabriseno
approved these changes
Aug 29, 2022
Collaborator
dgarciabriseno
left a comment
dgarciabriseno
left a comment
There was a problem hiding this comment.
Looks good, works great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.