Merged
Conversation
tdonohue
added
code task
1 APPROVAL
benbosman
approved these changes
Nov 30, 2020
Member
benbosman
left a comment
benbosman
left a comment
There was a problem hiding this comment.
For us at Atmire, this solution works as well. We don't have a need for the CI during non-main PRs, but no problem to include them.
I didn't test it, but the change looks correct to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion in Slack & PR DSpace/DSpace#3069 , this just updates our
build.ymlto run on every push/PR to the current branch. @abollini pointed out (in Slack) that this seems to be the ideal build process, as GitHub is smart enough to only use thebuild.ymlfor the current branch.