[Preview theme] Miscellaneous fixes for Preview Release - Part 2#399
Merged
tdonohue merged 22 commits intoDSpace:previewfrom May 17, 2019
Merged
[Preview theme] Miscellaneous fixes for Preview Release - Part 2#399tdonohue merged 22 commits intoDSpace:previewfrom
tdonohue merged 22 commits intoDSpace:previewfrom
Conversation
…some of the RDs it's based on were still pending
…er heapspace. The variables didn't work cross-platform
…utions/dspace-angular into preview-misc-fixes-2
paulo-graca
approved these changes
May 17, 2019
Contributor
paulo-graca
left a comment
paulo-graca
left a comment
There was a problem hiding this comment.
Great work. Nothing to point out.
tdonohue
approved these changes
May 17, 2019
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Looks good to me. I tested it and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends #398 to make sure all new changes are also applied to the new Mantis theme.