[DS-4236] fix issues with collection recent submissions#397
Merged
tdonohue merged 1 commit intoDSpace:masterfrom May 14, 2019
Merged
[DS-4236] fix issues with collection recent submissions#397tdonohue merged 1 commit intoDSpace:masterfrom
tdonohue merged 1 commit intoDSpace:masterfrom
Conversation
…ld be wrong, and would continually rerender
paulo-graca
approved these changes
May 14, 2019
Contributor
paulo-graca
left a comment
paulo-graca
left a comment
There was a problem hiding this comment.
It fixes issue "DS-4236 Flickering bug on Recent Submissions". Thank you @artlowel !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues with the most recent items section on collection homepages
The most recent items on a collection homepage were retrieved using ItemDataService instead of SearchService, and were therefore not actually the most recent items. This was already fixed in Resolvers for item, collection and community home page #288, but was broken again due to a merge.
The list was re-rendered whenever the pagination returned any event. I added a check for differences before a re-render.