This repository was archived by the owner on Feb 24, 2025. It is now read-only.
fix: pathfinder return value on failure#3244
Merged
Conversation
Always fill in all fields of PathfinderReturn on failure to avoid false positives for object in front (and thus reversing) #3242
If the unloader can't find a path, it'll retry first with either fruit avoidance or off-field penalty disabled, depending on what most likely caused the failure, then retry a second time with both disabled. #3242
"There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors." #3242
Relax constraints for first retry based on previous result (fruit or off-field penalty) #3242
schwiti6190
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always fill in all fields of PathfinderReturn on failure to avoid false positives for object in front (and thus reversing)
#3242