Allow achievements to have requirements#182
Merged
allenwq merged 6 commits intoCoursemology:masterfrom May 11, 2015
Merged
Conversation
There was a problem hiding this comment.
Extra empty line detected at block body beginning.
lowjoel
force-pushed
the
jsyeo/requirement-models
branch
3 times, most recently
from
583d74b to
fe10969
Compare
There was a problem hiding this comment.
Use each_with_object instead of reduce.
Member
Author
|
@allenwq the build is failing, can you run this locally and see if it fails on your computer? It runs fine on my own computer. |
lowjoel
force-pushed
the
jsyeo/requirement-models
branch
from
773e370 to
5b0b5f9
Compare
Member
|
@lowjoel Same exception as travis, I cannot run |
Member
Author
|
travis isn't failing at db:setup, it's failing at loading the factories. |
Member
|
Seems to be setup |
Member
Author
|
okay, going blind =.= not sure why it's broken though... |
Member
Author
|
Found the bug, going to fix in the gem. |
Member
|
👍 |
Member
Author
|
Waiting for SchemaPlus/schema_plus_core#2 |
lowjoel
force-pushed
the
jsyeo/requirement-models
branch
from
3fe03fd to
fb76773
Compare
Member
Author
|
This should work now. Review and merge when it all passes. |
This was referenced Apr 29, 2015
…for both the type and id columns are created.
…e we have more achievements and not just those that the test created.
lowjoel
force-pushed
the
jsyeo/requirement-models
branch
from
fb76773 to
64f2bd6
Compare
allenwq
added a commit
that referenced
this pull request
May 11, 2015
…dels Allow achievements to have requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #100.
Still not working, though.