Skip to content

Allow achievements to have requirements#100

Closed
jsyeo wants to merge 6 commits intoCoursemology:masterfrom
jsyeo:jsyeo-requirement-models
Closed

Allow achievements to have requirements#100
jsyeo wants to merge 6 commits intoCoursemology:masterfrom
jsyeo:jsyeo-requirement-models

Conversation

@jsyeo
Copy link
Contributor

@jsyeo jsyeo commented Feb 13, 2015

lol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.77% when pulling ccaff9e on jsyeo:jsyeo-requirement-models into 3e0b9b0 on Coursemology:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.77% when pulling ccaff9e on jsyeo:jsyeo-requirement-models into 3e0b9b0 on Coursemology:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.77% when pulling d38daef on jsyeo:jsyeo-requirement-models into 3e0b9b0 on Coursemology:master.

@@ -0,0 +1,4 @@
class Course::Requirement::Achievement < ActiveRecord::Base
acts_as :requirement, class_name: 'Course::Requirement'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Course::Requirement.name, so that if we break the identifiers we get a load-time error instead of a runtime error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments