Merged
Conversation
Contributor
Author
|
These tests probably need to be accompanied by a broader suite of some functions used by the functions in rff.py. For instance, |
Codecov Report
@@ Coverage Diff @@
## dscim-v0.4.0 #73 +/- ##
================================================
+ Coverage 46.43% 55.87% +9.43%
================================================
Files 17 17
Lines 1865 1865
================================================
+ Hits 866 1042 +176
+ Misses 999 823 -176 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kemccusker
added a commit
that referenced
this pull request
Apr 19, 2023
…egion-creates-chunk-issue Hot fix of some issues. Will fix checks in PR #73
kemccusker
reviewed
Apr 20, 2023
Member
kemccusker
left a comment
kemccusker
left a comment
There was a problem hiding this comment.
@davidrzhdu can you please add short docstring to each test briefly describing the behavior it tests? See preprocessing PR #67 for examples
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
kemccusker
reviewed
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.