Skip to content

Hot fix of some issues#82

Merged
kemccusker merged 4 commits intodscim-v0.4.0from
80-mismatched-order-of-region-creates-chunk-issue
Apr 19, 2023
Merged

Hot fix of some issues#82
kemccusker merged 4 commits intodscim-v0.4.0from
80-mismatched-order-of-region-creates-chunk-issue

Conversation

@davidrzhdu
Copy link
Copy Markdown
Contributor

The issues get resolved in this PR are:

  1. Add .load() to every call of EconVars in dscim.preprocessing.input_damages.py. This is for resolving the chunk issue.
  2. Convert output of dscim.preprocessing.input_damages.compute_ag_damages() to float32 to make Ag consistent with other sectors.
  3. Convert list passed to pandas.DataFrame.groupby() in dscim.utils.rff.py to string when grouping pandas.DataFrame by a single column. Passing list containing a single string to pandas.DataFrame.groupby() works well locally, but creates some weirdness on GitHub.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2023

Codecov Report

Merging #82 (7bf37fa) into dscim-v0.4.0 (f5d88b2) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           dscim-v0.4.0      #82      +/-   ##
================================================
- Coverage         40.53%   39.92%   -0.61%     
================================================
  Files                18       17       -1     
  Lines              1838     1866      +28     
================================================
  Hits                745      745              
- Misses             1093     1121      +28     
Impacted Files Coverage Δ
src/dscim/preprocessing/input_damages.py 0.00% <0.00%> (ø)
src/dscim/utils/rff.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Member

@kemccusker kemccusker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!

@kemccusker kemccusker merged commit fc2dc31 into dscim-v0.4.0 Apr 19, 2023
@kemccusker kemccusker deleted the 80-mismatched-order-of-region-creates-chunk-issue branch April 19, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants