Skip to content

[Game Server] Config download failure, silent deserialization, swallowed stack traces #400

@Flegma

Description

@Flegma

Summary

Error handling gaps in configuration loading and event processing.

Findings

  • MatchService.cs — downloads configs from GitHub with no error handling for network failure.
  • MatchService.cs — null matchData from JSON deserialization returns silently without logging.
  • ReadySystem.cs — exception ex.Message logged but stack trace omitted.

Impact

Match fails to start silently if GitHub unreachable. Deserialization failures undiagnosed.

Suggested Fix

Add try-catch with retry and fallback to bundled configs. Log full exception objects.


Related Issues (Error Handling Pattern)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1-highStability & reliabilityaudit-2026-03From March 2026 codebase auditerror-handlingMissing or incorrect error handlingservice:game-server5stackgg/game-server service

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions