[API] Swallowed async errors — Discord setup, Redis subs, job queues, unhandled rejections

[Flegma]

Summary

Multiple async operations use void prefix or lack error handlers, causing errors to be silently swallowed.

Findings

• AppModule — void this.discordBot.setup() not awaited, errors silently swallowed.
• SocketsService — Redis subscriptions and message handlers called with void, no error handlers.
• MatchesModule — multiple queue.add() calls with void, queue failures swallowed.
• main.ts — unhandledRejection handler only logs warning, doesn't exit or recover.

Impact

Service degradation goes unnoticed. Discord bot, Redis, or job queues could fail silently.

Suggested Fix

• Await critical async ops or add .catch() handlers.
• Add proper recovery to unhandledRejection handler.

---

Related Issues (Error Handling Pattern)

• [API] Swallowed async errors — Discord setup, Redis subs, job queues, unhandled rejections #376 — [API] Swallowed async errors
• [Web] Subscription & Apollo error handling — silent failures, swallowed errors #389 — [Web] Subscription & Apollo error handling
• [Game Server] Config download failure, silent deserialization, swallowed stack traces #400 — [Game Server] Config download & swallowed exceptions
• [Connector] Swallowed promises in Redis/system/demos & demo upload file deletion race #410 — [Connector] Swallowed promises & demo upload race

[Flegma]

Resolved by merged PR 5stackgg/api#141