Relax Sized requirements on the rng#126
Merged
str4d merged 1 commit intozkcrypto:release-0.14.0from Mar 9, 2025
Merged
Conversation
This was referenced Feb 26, 2025
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Mar 4, 2025
Depends: - zkcrypto/ff#126 - zkcrypto/ff#127 This is to provide an `ecdsa::SigningKey::try_from_rng` API (RustCrypto/signatures#915)
str4d
reviewed
Mar 9, 2025
baloo
force-pushed
the
baloo/relax-sized-rng
branch
from
4ae604c to
855bdd8
Compare
baloo
force-pushed
the
baloo/relax-sized-rng
branch
from
855bdd8 to
87b59a5
Compare
str4d
requested changes
Mar 9, 2025
baloo
force-pushed
the
baloo/relax-sized-rng
branch
from
87b59a5 to
1a12c4c
Compare
str4d
approved these changes
Mar 9, 2025
Member
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
utACK 1a12c4c
Changes to the core zkcrypto traits like this need to go through the zkcrypto RFC process. I am merging this PR to the 0.14.0 release branch so it can go into a pre-release for testing, but I will back it out of the release branch before publishing if it is not in a merged RFC.
(In the case of 0.14.0 I think it makes sense to have a single RFC covering all proposed changes to the ff traits, rather than one RFC per change.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stacked on #122