-
Notifications
You must be signed in to change notification settings - Fork 391
feat(batcher): enforce a min max_fee and min bump for replacements
#2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuArce
reviewed
Jul 10, 2025
Collaborator
JuArce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a warning note to the PR description about the new parameters needed in the config so we don't forget them
JuArce
requested changes
Jul 10, 2025
JuArce
reviewed
Jul 10, 2025
JuArce
approved these changes
Jul 10, 2025
JuArce
requested changes
Jul 11, 2025
Collaborator
JuArce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing docs
JuArce
approved these changes
Jul 11, 2025
Member
Author
|
Closed in favour of #2067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces two new validations when processing proofs:
max_feemust be at least 10 percent higher with respect to the original one.Important
Note: this pr requires two new variables in the batcher config:
How to test
ethereum_package:max_feesuch that it does not cover the32proofs batch, for example ifPROOFS_IN_BATCH=50, they should not be acceptedPROOFS_IN_BATCH<=32.10%percent. Run6.but with10<PROOFS_IN_BATCH<=32so that the batch is not build. Then check the log:Get the fee per proof and then pass a value that is below
MAX_FEE*1,1. For example if the batch of proofs starts withNONCE=0aligned submit --proving_system SP1 \ --proof scripts/test_files/sp1/sp1_fibonacci_5_0_0.proof \ --vm_program scripts/test_files/sp1/sp1_fibonacci_5_0_0.elf \ --private_key 0x92db14e403b83dfe3df233f83dfa3a0d7096f21ca9b0d6d6b8d88b2b4ec1564e \ --nonce 12 --max_fee $(MAX_FEE) \ --rpc_url http://localhost:8545 \ --network devnetMAX_FEE>=MAX_FEE*1,1, verify it gets replaced.Type of change
Checklist
testnet, everything else tostaging