fix: fix incorrect string comparison in OPERATOR_ADDRESS check#1807
Closed
hexcow wants to merge 3 commits intoyetanotherco:testnetfrom
Closed
fix: fix incorrect string comparison in OPERATOR_ADDRESS check#1807hexcow wants to merge 3 commits intoyetanotherco:testnetfrom
hexcow wants to merge 3 commits intoyetanotherco:testnetfrom
Conversation
Contributor
|
Opened issue #1853 |
14 tasks
Contributor
MauroToscano
approved these changes
Apr 4, 2025
MauroToscano
approved these changes
Apr 8, 2025
Contributor
|
Thanks for reporting the issue, we have solved it along with others similar checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a bug in the script where
-eqwas used to check ifOPERATOR_ADDRESSis empty. Since-eqis for numeric comparisons, this caused an error:I fixed it by replacing
-eq ""with-z, which correctly checks for an empty string.Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostagingp.s. Everything works as expected now 🚀