Conversation
| INSTALL_PATH="$WP_CORE_DIR/src/wp-content/themes/$PROJECT_SLUG" | ||
|
|
||
| # Rsync the files into the right location | ||
| mkdir -p "$INSTALL_PATH" |
There was a problem hiding this comment.
I wonder, why was --exclude .git/hooks included here and originally for the plugin project type. I would think that excluding all of .git should be what is done instead?
There was a problem hiding this comment.
Yeah, I didn't dive deep into that because I didn't really understand the code. I just did a copy and paste.
There was a problem hiding this comment.
Why don't you go ahead and change .git/hooks to .git. I think that is what should be done for both here.
There was a problem hiding this comment.
I guess by removing the hooks it was preventing the pre-commit hook from executing?
There was a problem hiding this comment.
But are any git commands even executed when the files are synced to the INSTALL_PATH?
There was a problem hiding this comment.
I'll update both of them. 👍
|
@valendesigns I was wondering if you would mind me pushing the suggested changes from the code review? It would be very cool to finally have phpunit support for themes. |
|
@westonruter & @kasparsd This is ready to be reviewed. Seems the coverage clover was not generating since this commit 39753b9 was introduced back in March so I had to fix that. I've tested that the changes work with my Archetype theme, here's a passing build with coverage https://travis-ci.org/valendesigns/archetype/jobs/264974727 However, I think there's might be something wrong with the Coveralls connection since the coverage clover was generated but never made it to Coveralls https://coveralls.io/github/valendesigns/archetype It seems all of our plugins have not been working with Coveralls for a while and nobody noticed. 😞 |
kasparsd
left a comment
kasparsd
left a comment
There was a problem hiding this comment.
Works great! Tested with a private theme.
|
@valendesigns I did notice something wrong with the Coveralls a few months ago hence switching back to older commits. However, the latest commit still does not seem to work either. Coverage clover is generated https://travis-ci.org/ninecodes/wp-social-manager/jobs/266328984 yet nothing is pushed to Coveralls for the latest build https://coveralls.io/github/ninecodes/wp-social-manager. What do I do wrong here? I've figured out that the issue is because of the entire Reverting the exclusion to just the |
5 participants
This PR adds support for themes to be unit tested. Additionally, it provides a way to clone plugin dependencies for the theme by adding a
THEME_DEPSvariable to thetravis.ymlor.dev-libfiles that consists of a list of URLs separated by commas.