Stream 3: Fix \WP_Stream\List_Table namespace so live updates work correctly#735
Closed
rob wants to merge 1 commit intoxwp:masterfrom
rob:fix-live-updates
Closed
Stream 3: Fix \WP_Stream\List_Table namespace so live updates work correctly#735rob wants to merge 1 commit intoxwp:masterfrom rob:fix-live-updates
rob wants to merge 1 commit intoxwp:masterfrom
rob:fix-live-updates
Conversation
Fixes "PHP Fatal error: Class 'WP_Stream\\WP_Stream_List_Table' not found" error.
Contributor
|
Thanks so much @rob. Wow - how did you get that github username!? Your PR looks great, and I've tested it and it works great. Would you mind issuing it against the Thanks. |
Contributor
|
Also, I have no idea how I missed this. |
Contributor
Author
|
OK @lukecarbis, I just issued it against the And I registered this username when GitHub was first announced, I think. It sucks when people use the shorthand @rob to reference other people and I end up getting notifications though when it's not related to me. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a fresh Stream 3 install, live updates fail silently with the following error:
Due to PHP's namespaces, this needs to be
\WP_Stream\List_Tableor justList_Table, notWP_Stream_List_Table. This commit fixes this so live updates work correctly again like they should.