Skip to content

Stream 3: Fix \WP_Stream\List_Table namespace so live updates work correctly#735

Closed
rob wants to merge 1 commit intoxwp:masterfrom
rob:fix-live-updates
Closed

Stream 3: Fix \WP_Stream\List_Table namespace so live updates work correctly#735
rob wants to merge 1 commit intoxwp:masterfrom
rob:fix-live-updates

Conversation

@rob
Copy link
Copy Markdown
Contributor

@rob rob commented Aug 25, 2015

On a fresh Stream 3 install, live updates fail silently with the following error:

PHP Fatal error:  Class 'WP_Stream\\WP_Stream_List_Table' not found in /[...]/wp-content/plugins/stream/classes/class-live-update.php on line 179

Due to PHP's namespaces, this needs to be \WP_Stream\List_Table or just List_Table, not WP_Stream_List_Table. This commit fixes this so live updates work correctly again like they should.

Fixes "PHP Fatal error:  Class 'WP_Stream\\WP_Stream_List_Table' not found" error.
@lukecarbis lukecarbis added the bug label Aug 25, 2015
@lukecarbis lukecarbis added this to the 3.0.1 milestone Aug 25, 2015
@lukecarbis
Copy link
Copy Markdown
Contributor

Thanks so much @rob. Wow - how did you get that github username!?

Your PR looks great, and I've tested it and it works great. Would you mind issuing it against the develop branch instead of master?

Thanks.

@lukecarbis
Copy link
Copy Markdown
Contributor

Also, I have no idea how I missed this.

@rob
Copy link
Copy Markdown
Contributor Author

rob commented Aug 26, 2015

OK @lukecarbis, I just issued it against the develop branch.

And I registered this username when GitHub was first announced, I think. It sucks when people use the shorthand @rob to reference other people and I end up getting notifications though when it's not related to me. :-)

@lukecarbis lukecarbis closed this Aug 26, 2015
@rob rob deleted the fix-live-updates branch September 1, 2015 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants