Skip to content

Update wp_stream_get_sites() to work consistently with the limit/number argument#1258

Merged
kasparsd merged 1 commit intoxwp:developfrom
dd32:fix/wp_stream_get_sites/large_networks
May 11, 2021
Merged

Update wp_stream_get_sites() to work consistently with the limit/number argument#1258
kasparsd merged 1 commit intoxwp:developfrom
dd32:fix/wp_stream_get_sites/large_networks

Conversation

@dd32
Copy link
Copy Markdown
Contributor

@dd32 dd32 commented May 4, 2021

Update wp_stream_get_sites() to work consistently with the limit/number argument

This also changes it so that by default, list every site rather than the first 100 encountered on networks.

This also changes it to listing all sites by default, rather than only the first 100.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Describe a bug fix included in this release.
  • New: Describe a new feature in this release.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

…umber` argument

This also changes it so that by default, list every site rather than the first 100 encountered on networks.
Copy link
Copy Markdown
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @dd32, it looks good!

Is this ready to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants