Use longer option names in install_db() to avoid stalling CIs#255
Merged
schlessera merged 1 commit intowp-cli:masterfrom Apr 1, 2020
stevegrunwell:fix/install-tests-with-empty-password
Merged
Use longer option names in install_db() to avoid stalling CIs#255schlessera merged 1 commit intowp-cli:masterfrom stevegrunwell:fix/install-tests-with-empty-password
install_db() to avoid stalling CIs#255schlessera merged 1 commit intowp-cli:masterfrom
stevegrunwell:fix/install-tests-with-empty-password
Conversation
Since some platforms (such as Travis CI) use empty passwords for the database user, passing an empty string for `$DB_PASS` can result in a TTY prompt, e.g.: ``` $ DB_USER=someuser DB_PASS="" mysql -u "$DB_USER" -p"$DB_PASS" -e 'show databases;' Enter password: ``` This commit rewrites the call to use the longer option names (`--user`, `--password`, and `--execute`) to prevent empty passwords from being interpreted as "please ask me to provide my password in an interactive prompt."
stevegrunwell
added a commit
to assertwell/wp-core-test-framework
that referenced
this pull request
Mar 26, 2020
stevegrunwell
added a commit
to assertwell/wp-core-test-framework
that referenced
this pull request
Mar 26, 2020
* Manually apply the patch from wp-cli/scaffold-command#255 ahead of official merger. https://github.com/assertwell/wp-core-test-framework/releases/tag/v0.1.1
schlessera
approved these changes
Apr 1, 2020
schlessera
added
the
command:scaffold-plugin-tests
schlessera
changed the title
schlessera
changed the title
install_db() to avoid stalling CIs
Member
|
Thanks for the PR, @stevegrunwell ! |
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
…ty-password Use longer option names in `install_db()` to avoid stalling CIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some platforms (such as Travis CI) use empty passwords for the database user, passing an empty string for
$DB_PASScan result in a TTY prompt, e.g.:In a CI environment, this can cause the entire pipeline to hang until cancelled.
This PR rewrites the call to use the longer option names (
--user,--password, and--execute) to prevent empty passwords from being interpreted as "please ask me to provide my password in an interactive prompt."