Make use of report_batch_operation_results() for install commands #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
commented
Oct 4, 2018
|
|
||
| if ( in_array( $language_code, $available, true ) ) { | ||
| \WP_CLI::warning( "Language '{$language_code}' already installed." ); | ||
| \WP_CLI::log( "Language '{$language_code}' already installed." ); |
Contributor
Author
There was a problem hiding this comment.
Is this a skip or a success? Looks like media would treat it as a success.
https://github.com/wp-cli/media-command/blob/337459d/src/Media_Command.php#L590-L600
Contributor
Author
There was a problem hiding this comment.
Looking at the success message, I think we can leave it as is.
Success: Installed 0 of 1 languages (1 skipped).
ocean90
changed the title
swissspidy
approved these changes
Oct 5, 2018
|
@schlessera Is there anything stopping this from being merged? |
Contributor
Author
|
We may want to consider using a table for the output here too, see #64 (comment). |
Member
|
I think we can optimize the output in follow-up PRs. |
schlessera
pushed a commit
that referenced
this pull request
Jan 5, 2022
Make use of report_batch_operation_results() for install commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61.
Example output: