Skip to content

Strip HTML tags from multisite user signup validation errors #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 5 commits into from
Mar 16, 2026
+40 −2
Merged

Strip HTML tags from multisite user signup validation errors #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fafabad
Initial plan
Copilot Mar 15, 2026
2a6f897
Fix: strip HTML tags from multisite user signup validation errors
Copilot Mar 15, 2026
30eeaaa
Merge branch 'main' into copilot/fix-error-message-creating-user
swissspidy Mar 16, 2026
b5e56b5
Fix test
swissspidy Mar 16, 2026
08d3262
Potential fix for pull request finding
swissspidy Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions features/user.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,43 @@ Feature: Manage WordPress users
Bob Jones
"""

# The error message changed in WP 5.9.
@less-than-wp-5.9
Scenario: Creating a user with an existing email in multisite shows a clean error message
Given a WP multisite install

When I run `wp user create bobjones bobjones@example.com`
Then STDOUT should not be empty

When I try `wp user create bobjones2 bobjones@example.com`
Then STDERR should contain:
"""
Sorry, that email address is already used!
"""
And STDERR should not contain:
"""
<
"""
And the return code should be 1

@require-wp-5.9
Scenario: Creating a user with an existing email in multisite shows a clean error message
Given a WP multisite install

When I run `wp user create bobjones bobjones@example.com`
Then STDOUT should not be empty

When I try `wp user create bobjones2 bobjones@example.com`
Then STDERR should contain:
"""
This email address is already registered.
"""
And STDERR should not contain:
"""
<
"""
And the return code should be 1

Scenario: Managing user roles
Given a WP install

Expand Down
5 changes: 3 additions & 2 deletions src/User_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,8 @@ public function create( $args, $assoc_args ) {
if ( is_multisite() ) {
$result = wpmu_validate_user_signup( $user->user_login, $user->user_email );
if ( ! empty( $result['errors']->errors ) ) {
WP_CLI::error( $result['errors'] );
$error_message = implode( ' ', array_map( 'wp_strip_all_tags', $result['errors']->get_error_messages() ) );
WP_CLI::error( $error_message );
}
$user_id = wpmu_create_user( $user->user_login, $user->user_pass, $user->user_email );
if ( ! $user_id ) {
Expand Down Expand Up @@ -1228,7 +1229,7 @@ public function import_csv( $args, $assoc_args ) {
if ( is_multisite() ) {
$result = wpmu_validate_user_signup( $new_user['user_login'], $new_user['user_email'] );
if ( ! empty( $result['errors']->errors ) ) {
WP_CLI::warning( $result['errors'] );
WP_CLI::warning( implode( ' ', array_map( 'wp_strip_all_tags', $result['errors']->get_error_messages() ) ) );
continue;
}
$user_id = wpmu_create_user( $new_user['user_login'], $new_user['user_pass'], $new_user['user_email'] );
Expand Down
Loading