Skip to content

Conversation

@JeroenDeDauw
Copy link
Contributor

No description provided.

@JeroenDeDauw
Copy link
Contributor Author

Right now people on PHP 8.x get data-model 9.2, which is not helping anyone. The tests all pass on PHP 8.0.

@JeroenDeDauw
Copy link
Contributor Author

@addshore @manicki

@JeroenDeDauw
Copy link
Contributor Author

Why does this take 20 days?

@mariushoch
Copy link
Member

Manually ran the tests in a PHP 8.0.0 container and this seems to work fine.

@mariushoch mariushoch merged commit 1930078 into wmde:master Dec 31, 2020
@JeroenDeDauw JeroenDeDauw deleted the patch-2 branch December 31, 2020 19:48
@manicki
Copy link
Member

manicki commented Jan 4, 2021

Why does this take 20 days?

Apologies, this fell off our radar apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants