Skip to content

Support shortened RFC 822 dates #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
witochandra merged 2 commits into from
Aug 17, 2020
Merged

Support shortened RFC 822 dates #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
040c026
Merge pull request #1 from witochandra/master
alexandergottlieb Aug 17, 2020
27e40c8
support shortened RFC 822 dates
alexandergottlieb Aug 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/util/datetime.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
import 'package:intl/intl.dart';

var rfc822DateFormat = DateFormat('EEE, dd MMM yyyy HH:mm:ss Z', 'en_US');
const rfc822DatePattern = 'EEE, dd MMM yyyy HH:mm:ss Z';

DateTime parseDateTime(dateString) {
if (dateString == null) return null;
return _parseRfc822DateTime(dateString) ?? _parseIso8601DateTime(dateString);
}

DateTime _parseRfc822DateTime(dateString) {
DateTime _parseRfc822DateTime(String dateString) {
try {
return rfc822DateFormat.parse(dateString);
final length = dateString?.length?.clamp(0, rfc822DatePattern.length);
final trimmedPattern = rfc822DatePattern.substring(0, length); //Some feeds use a shortened RFC 822 date, e.g. 'Tue, 04 Aug 2020'
final format = DateFormat(trimmedPattern, 'en_US');
return format.parse(dateString);
} on FormatException {
return null;
}
Expand Down