fix: Make sure docs styles work as intended, add note about Astro v5#160
fix: Make sure docs styles work as intended, add note about Astro v5#160louisescher merged 1 commit intomainfrom
Conversation
Dokploy Preview Deployment
|
|
📝 WalkthroughWalkthroughThe pull request updates Astro configuration to refactor CSS injection strategy for the UI integration, separating Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test ResultsDetails
Suites300 passed, 0 failed, and 0 other
Github Test Reporter by CTRF 💚 |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/src/content/docs/docs/index.mdx`:
- Around line 80-85: The example is missing the Tailwind integration import used
in defineConfig; add an import for the tailwind integration (import tailwind
from '@astrojs/tailwind') so the call to tailwind() alongside ui() resolves
correctly—update the top of the file where defineConfig and ui are imported to
also import tailwind.
- Around line 21-24: Update the paragraph under the "Using `@studiocms/ui` with
Astro 4 or 5" summary to explicitly state that the version constraint applies to
Astro (not the UI package); change the sentence that currently reads "As for
Astro v4, `@studiocms/ui` requires version `v4.5.0` or higher" to something like
"For Astro v4, Astro v4.5.0 or higher is required and the
`experimental.directRenderScript` flag must be enabled" (or "Requires Astro
v4.5.0+ with `experimental.directRenderScript` enabled"), keeping the
`experimental.directRenderScript` mention intact so readers clearly understand
the requirement applies to Astro.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f82a6bfa-fa7b-4f96-91f1-34be38cc8397
📒 Files selected for processing (2)
docs/astro.config.mtsdocs/src/content/docs/docs/index.mdx
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
Summary by CodeRabbit
Documentation
Chores