[TSX] infer props and params from getStaticPaths#873
Merged
natemoo-re merged 3 commits intomainfrom Oct 4, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: f6d9524 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
reviewed
Oct 4, 2023
Princesseuh
approved these changes
Oct 4, 2023
Member
Princesseuh
left a comment
There was a problem hiding this comment.
Awesome work! People will be very happy about this.
5 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getStaticPathsexportAstro.propsandAstro.paramscan be inferred from the return value ofgetStaticPathsPropsdefinitions take precedence over inferred definitions, so this should be compatible with the existing recommended pattern below:satisfiesclause forgetStaticPathsitself, but that can be left for a follow-up PRTesting
Tests added
Docs
We should update the docs when this lands upstream in the language tools!