docs(contributing): commands to install jest globally#777
Merged
evenstensberg merged 5 commits intowebpack:masterfrom Mar 8, 2019
Merged
docs(contributing): commands to install jest globally#777evenstensberg merged 5 commits intowebpack:masterfrom
evenstensberg merged 5 commits intowebpack:masterfrom
Conversation
Add commands to install jest globally for running individual tests ISSUES CLOSED: webpack#775
|
|
Contributor
|
No need to install when |
Add yarn before jest to grab the local binary of jest from node_modules to run individual tests ISSUES CLOSED: webpack#775
Add docs to either install jest or use the locally installed binaries from node_modules ISSUES CLOSED: webpack#775
Member
Author
|
@playma256 updated, looks better? |
matheus1lva
approved these changes
Mar 6, 2019
rishabh3112
approved these changes
Mar 6, 2019
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
LGTM @anshumanv ,
Left a suggestion for you.
thisaayush
approved these changes
Mar 6, 2019
Updated instructions to run individual tests in contributing.md ISSUES CLOSED: webpack#775
Added : at the end of paragraphs ISSUES CLOSED: webpack#775
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add commands to install jest globally for running individual tests
ISSUES CLOSED: #775
What kind of change does this PR introduce?
Docs
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Yes
Summary
Added commands to install jest cli for running tests.
Does this PR introduce a breaking change?
No
Other information
NA