fix(processPattern): don't add 'glob' as directory when it is a file (contextDependencies)#296
Merged
michael-ciniawsky merged 1 commit intowebpack:masterfrom Oct 18, 2018
alan-agius4:fix_glob_exclude_file
Merged
fix(processPattern): don't add 'glob' as directory when it is a file (contextDependencies)#296michael-ciniawsky merged 1 commit intowebpack:masterfrom alan-agius4:fix_glob_exclude_file
'glob' as directory when it is a file (contextDependencies)#296michael-ciniawsky merged 1 commit intowebpack:masterfrom
alan-agius4:fix_glob_exclude_file
Conversation
In some cases we might have someone like this which in that cause we wouldn't want to add the parent directory as a webpack context dependencies
```
{
ignore: [ '.gitkeep', '**/.DS_Store', '**/Thumbs.db' ],
from: { glob: 'favicon.ico', dot: true },
toType: 'dir',
fromType: 'glob'
}
```
alan-agius4
changed the title
glob is a file
michael-ciniawsky
changed the title
glob is a filecontextDependencies when glob is a file
alexander-akait
approved these changes
Oct 11, 2018
Member
|
/cc @michael-ciniawsky looks regression |
yannickcr
approved these changes
Oct 17, 2018
michael-ciniawsky
changed the title
contextDependencies when glob is a file'glob' as directory when it is a file (contextDependencies)
michael-ciniawsky
approved these changes
Oct 18, 2018
Contributor
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
@alan-agius4 Thx
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 4 (important)
severity: 3 (broken)
status: Pending
labels
Contributor
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases we might have someone like this which in that cause we wouldn't want to add the parent directory as a webpack context dependencies