doc: improve terminology #27152
Merged
doc: improve terminology #27152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to the effort in the Node.js project to rename the primary branch to main we are also looking to remove other references to related terminology. One instance is through the copy of this file that we have from wpt as part of the Node.js tests: https://github.com/nodejs/node/blob/master/test/fixtures/wpt/common/security-features/README.md Generally we want changes in dependencies landed upstream first before updating in the Node.js repo which is why I'm submitting the PR to change it here first, to be followed by updating wpt in Node.js core to pull in the change. Signed-off-by: Michael Dawson <[email protected]>
Ms2ger
approved these changes
Jan 20, 2021
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Jan 21, 2021
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <[email protected]>
Trott
pushed a commit
to mhdawson/io.js
that referenced
this pull request
Jan 27, 2021
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#37011 Reviewed-By: Milad Fa <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 2, 2021
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #37011 Reviewed-By: Milad Fa <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the effort in the Node.js project to rename
the primary branch to main we are also looking to
remove other references to related terminology.
One instance is through the copy of this file that
we have from wpt as part of the Node.js tests:
https://github.com/nodejs/node/blob/master/test/fixtures/wpt/common/security-features/README.md
Generally we want changes in dependencies landed
upstream first before updating in the Node.js repo
which is why I'm submitting the PR to change it
here first, to be followed by updating wpt in
Node.js core to pull in the change.
Signed-off-by: Michael Dawson [email protected]