Add some initial tests for JSON modules. #16734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
Contributor
Author
|
Note to self: some CORS tests could be useful too. CC @littledan |
Member
|
Chrome added some logic for |
domenic
approved these changes
May 10, 2019
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM as a start. For posterity, additional ideas for tests (potentially best done by the first implementer):
- Non-JSON content types get rejected, including tricky cases like @annevk pointed out.
- Test that there are no non-default imports. (Maybe easiest to test with
import().) - Test non-Window contexts. (Easy: using
.any.js+import(). Harder: using module workers which nobody ships yet, but Chrome has behind a flag.) - Test JSON files containing non-objects (null, true, false, array)
| @@ -0,0 +1,21 @@ | |||
| <!DOCTYPE html> | |||
| <meta charset=utf-8> | |||
| <title>JSON modules: Content-Type</title> | |||
Member
|
Also there are a lot of tests in the JS modules directory that might benefit from porting. For example testing that if you have module A with side effects, that imports JSON module B containing invalid JSON, asserting that the side effects of A do not happen. /cc @nyaxt and @hiroshige-g as folks who helped with a lot of the test coverage for JS modules. |
2 tasks
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 2, 2019
As explained at WICG/webcomponents#839 the current setup is insecure. Tests are now marked as "tentative": web-platform-tests/wpt#16734. This reverts db03474.
zcorpan
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 6, 2019
As explained at WICG/webcomponents#839 the current setup is insecure. Tests are now marked as "tentative": web-platform-tests/wpt#16734. This reverts db03474.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#4407.