Skip to content

Fix FreeBSD compile error #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vthiery merged 3 commits into from
Jan 25, 2023
Merged

Fix FreeBSD compile error #47

vthiery merged 3 commits into from
Jan 25, 2023

Conversation

@jeremiahpslewis
Copy link
Contributor

@jeremiahpslewis jeremiahpslewis commented Jan 24, 2023 •
edited
Loading

Found while building Valhalla for Julia: JuliaPackaging/Yggdrasil#6127

kevinkreiser
kevinkreiser approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@kevinkreiser kevinkreiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's too bad we cant have infinite CI configurations because then we could have a build for all platforms. we can just take your word for this one though I think

@kevinkreiser
Copy link
Collaborator

kevinkreiser commented Jan 24, 2023

@vthiery what do you think? I think the ifdef makes it harmless since all but freebsd will make use of this code. IMHO it's not a strong enough case to build a CI job for it.

@vthiery
Copy link
Owner

vthiery commented Jan 25, 2023

@vthiery what do you think? I think the ifdef makes it harmless since all but freebsd will make use of this code. IMHO it's not a strong enough case to build a CI job for it.

I agree that setting up a CI for this would probably be overkill at this point.

@vthiery vthiery merged commit 829e85f into vthiery:master Jan 25, 2023
@jeremiahpslewis jeremiahpslewis deleted the patch-1 branch January 25, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

@vthiery vthiery vthiery approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremiahpslewis @kevinkreiser @vthiery