Add multipart content type

[jellejurre]

No description provided.

[jellejurre]

This is required for vrchatapi/specification#408 to be merged

[C0D3-M4513R]

The sed statement changes nothing for me on the master branch.
Even grep "TODO: support file upload for" src/apis/files_api.rs comes back with nothing.

Did you want this to be a Draft PR?

[jellejurre]

That's corrcect, it only changes stuff from the following pr:

This is required for vrchatapi/specification#408 to be merged

[C0D3-M4513R]

Okay, but then the documentation of the specification is wrong.
In the specification you write:

                file:
                  type: string
                  format: binary
                  description: The binary blob of the png file.

Yet in this pr you interpret file as a filename to open and read

[jellejurre]

Yes, that's how the generators create it, the generators create a PathBuf, which (as I understand it) store a Path to a file on disk

[C0D3-M4513R]

Then the description should read The path to the file to be uploaded instead.

[C0D3-M4513R]

Also using a blocking file read in an async context is not ideal either in this scenario (though I can totally understand that choice)

[jellejurre]

Then the description should read The path to the file to be uploaded instead.

The issue with this is that it depends on the generator :)

The C# generator takes in a byte stream

[jellejurre]

Also using a blocking file read in an async context is not ideal either in this scenario (though I can totally understand that choice)

Honestly the choice was because I don't know almost anything about rust async, I didnt realise that the file reading was sync, I can see if I can turn it into async in a bit

[C0D3-M4513R]

I can see if I can turn it into async in a bit

With the current dependencies std it's imo not possible.
We'll have to pull in some helper crate(s). Something like async-std or tokio (though I think the first choice is more versatile for consumers)

[jellejurre]

Ah

Well realistically the images won't be too big so do we think that's worth it?

I feel like it might be fine like this

[C0D3-M4513R]

Oh also you use .unwrap(), which is 100% off-limits for us as a crate.

[jellejurre]

Yeah that's fair lol

[C0D3-M4513R]

@jellejurre Can you look at these changes?

[C0D3-M4513R]

Wait, now that I'm thinking about it again, couldn't we just patch the sdk and have the user supply s byte stream and mime type?

Is that a better approach?

[jellejurre]

Looks good to me, works and gives a proper error when handing a non-existent file

[jellejurre]

Wait, now that I'm thinking about it again, couldn't we just patch the sdk and have the user supply s byte stream and mime type?

Is that a better approach?

Also possible, fine by me and probably more extendable in the long run

[C0D3-M4513R]

Writing a regex replace in regex101.com for that is no problem, but I can't get the regex to actually work.

[jellejurre]

honestly, throw the regex in chatgpt, it's great at regexes lol

[C0D3-M4513R]

I finally got the regex.
I couldn't use sed, because it isn't powerful enough.

[C0D3-M4513R]

Only thing left is to test this again and then to merge (if you have perms, feel free to merge yourself. If not, I'll merge it, when you said, that it works)

[jellejurre]

let mut buffer = Vec::new();
let a = File::open("./image.png").unwrap().read_to_end(&mut buffer);
let output = vrchatapi::apis::files_api::upload_icon(&config, buffer, "image.png", "image/png")
    .await
    .unwrap();

this works great, LGTM