-
Notifications
You must be signed in to change notification settings - Fork 3k
[feat] Wandb Timing: Add more detailed timing of gen_sequence and weights resharding #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vermouth1992
merged 8 commits into
volcengine:main
from
ETOgaosion:add_weights_transfer_timing
Jun 6, 2025
Merged
[feat] Wandb Timing: Add more detailed timing of gen_sequence and weights resharding #1834
vermouth1992
merged 8 commits into
volcengine:main
from
ETOgaosion:add_weights_transfer_timing
Jun 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermouth1992
reviewed
Jun 4, 2025
verl/utils/timing_utils.py
Outdated
| @@ -0,0 +1,39 @@ | |||
| # Copyright 2024 Bytedance Ltd. and/or its affiliates | |||
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move this to verl/utils/debug/performance.py?
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, make sense to me, didn't find this in the same directory.
Collaborator
|
LGTM |
5c18a45 to
c77ffca
Compare
85dc28e to
3788fc2
Compare
vermouth1992
approved these changes
Jun 6, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 10, 2025
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
TimurTaepov
pushed a commit
to giorgossideris/verl
that referenced
this pull request
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Wandb Timing: Add more detailed timing of gen_sequence and weights resharding.
High-Level Design
Specific Changes
API
Usage Example
# Add code snippet or script demonstrating how to use thisTest
Additional Info.
Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.